Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action-sheet): 新增 ActionSheet组件 #471

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat(action-sheet): 新增 ActionSheet组件 #471

wants to merge 16 commits into from
+1,001 −9

Conversation

TianlunXiong
Copy link
Contributor

@TianlunXiong TianlunXiong commented Aug 19, 2024 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #429

💡 需求背景和解决方案

新增 ActionSheet 动作面板 组件，对齐vue版本

image

📝 更新日志

  • feat(ActionSheet): 新增 ActionSheet 组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

失败

HaixingOoO
HaixingOoO reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

onSelected={(idx) => {
    const found = items?.[idx];

    onSelected?.(found, idx);

    onClose?.('select');

    setInnerVisible(false);
  }}

ActionSheetList和ActionSheetGrid好像一樣的吧？可以申明個函數是不是更好？

anlyyao
anlyyao reviewed Aug 26, 2024
View reviewed changes
site/mobile/mobile.config.js Outdated Show resolved Hide resolved
src/action-sheet/ActionSheet.tsx Outdated Show resolved Hide resolved
src/action-sheet/ActionSheetList.tsx Show resolved Hide resolved
src/action-sheet/style/index.less Outdated Show resolved Hide resolved
src/action-sheet/_example/align.jsx Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator

anlyyao commented Aug 26, 2024

企业微信截图_1e7c6bbb-c127-4f03-a00c-ab3b75ced7a9

@anlyyao anlyyao requested a review from HaixingOoO August 28, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anlyyao anlyyao anlyyao left review comments

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

@jarmywang jarmywang Awaiting requested review from jarmywang jarmywang is a code owner

@HaixingOoO HaixingOoO Awaiting requested review from HaixingOoO

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【ActionSheet新组件】任务单
3 participants
@TianlunXiong @anlyyao @HaixingOoO